Install cert-manager#254
Open
Jakob-Naucke wants to merge 1 commit intotrusted-execution-clusters:mainfrom
Open
Install cert-manager#254Jakob-Naucke wants to merge 1 commit intotrusted-execution-clusters:mainfrom
Jakob-Naucke wants to merge 1 commit intotrusted-execution-clusters:mainfrom
Conversation
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#196 CI is failing because cert-manager is never installed. That's because CI checks out from main, not from PR, for cluster setup. That's a problem with the CI, but until settling if CI is going to change a lot, I'm proposing to put the installation in a separate PR. Tested locally.